target_stats: trim comments from the bzl files Summary: The target_stats bzl files accumulated comments that restate what the code already says -- what a provider field holds, what write_json(with_inputs) does, what other_outputs is for. That is the API's job, and a comment that paraphrases the line beneath it is one more thing to keep in sync. Removes 58 lines of comment across the prelude target…
Update flate2 from 1.1.9 to 1.1.10 (second attempt) Summary: The WhatsApp crash that caused the revert in {D120009380} is resolved by {D120014105}. Reviewed By: capickett Differential Revision: D120031636 fbshipit-source-id: 60fe614f9b5661e3efbb189380692c841d0bd61a
Exclude the LLVM lit macros from buck2's prelude ci_hints Summary: Three `ci_hint` glob lists hint on all of `tools/build_defs/**`, which covers `tools/build_defs/llvm` -- the LLVM build macros. None of the hinted tests use them, so editing an LLVM macro pulls in every Apple rule test, every non-isolated buck2 e2e test, and the sample build jobs. Exclude to avoid unnecessary broad CI jobs and impr…
No-op generic typetag registration on wasm Summary: The starlark-rust OSS CI wasm job (`ci_oss_wasmtime.sh`, mirrored internally by `fbcode//buck2/scripts/oss:starlark-rust-oss`) builds `starlark` for `wasm32-wasip1`. Since the generic typetag auto-registration landed (`matchers.rs` / `function.rs` monomorphization constructors, 2026-08-13), that build dies in `__pagable_emit_generic_typetag_regis…
Layer `.bucksettings.local.toml` in home dir over repo root settings Summary: Parses `.bucksettings.local.toml` from home dir. Home-local settings are recursively merged over the repo-root `.bucksettings.toml`. The pipeline is now discover settings files -> parse into tables -> merge into one table -> deserialize into `BuckSettingsData`. Adds unit coverage for layered parsing and an e2e test verif…
Pin macOS OSS CI to macos-14 to unbreak Build and test Summary: The `macos-build-and-test` job in the OSS "Build and test" workflow (and the sibling `macos-build-examples` job in "Build and Examples") regressed again after GitHub's `macos-latest` label advanced to the `macos-15` runner image. On `macos-15`, `xcode-version: latest-stable` selects an Xcode/SDK that mis-targets the deployment SDK and…
windows-sys: enable WindowsFilteringPlatform + Authorization Summary: Enable the WFP (Windows Filtering Platform), Security Authorization, and System Rpc features on the `windows-sys` crate so the Windows sandbox (sandbox-runtime/windows-native-sandbox-rs) can install network-isolation filters. Win32_Networking_WinSock comes in transitively. Generated by `reindeer buckify` (third-party/rust/Cargo.…
fix index overflow in enumerate with large start Summary: **Index overflow in `enumerate` with a large start** The per-element index is built as `k as i32 + start`, so when the caller passes a `start` near `i32::MAX` the addition overflows on the first elements rather than at some unreachable list length. Cause is doing the arithmetic in `i32` even though Starlark integers are arbitrary precision,…
Avoid heap allocations in dep-file digest comparisons Summary: `check_remote_dep_file_entry` was calling `.to_vec()` on digest byte slices just to compare them against `Vec<u8>` fields from the proto. Compare `&[u8]` slices directly instead, eliminating 4 unnecessary heap allocations per remote dep-file cache check. Reviewed By: scottcao Differential Revision: D106082425 fbshipit-source-id: e1d81b…
Fix broken @oss-disable markers that break OSS builds Summary: Several prelude files had `# oss-disable` only on the closing line of multi-line statements. Codesync strips marked lines individually, so this left dangling syntax (unclosed `load(` calls, empty `if False:` bodies) that caused Starlark parse errors in OSS builds. Fixes: - Multi-line `load()` statements: mark every line with `# oss-dis…
Fix rustdoc private_intra_doc_links issue in pagable storage trait Summary: The issue https://github.com/facebook/buck2/actions/runs/25183757994/job/73835505180 shows ``` ERROR: Documentation warning: warning: public documentation for `store_data` links to private item `PagableData::compute_key` --> pagable/src/storage/traits.rs:76:11 | 76 | /// [`PagableData::compute_key`]; if the same data is st…
Derive StarlarkPagable for LocalSlotId and LocalAsValue Summary: Derives `StarlarkPagable` for `LocalSlotId` and `LocalAsValue`. Reviewed By: cjhopman Differential Revision: D96243744 fbshipit-source-id: 2e7e3098618e3a0aeec12d2432ede16f0dde0fce
Fix cargo build Summary: New games crate introduced rand v0.10 on top of rand v0.9 and v0.8 that buck2 was using, which broke cargo build. This diff properly labels all usages of rand in Cargo.toml in their proper versions to fix cargo build Reviewed By: AishwaryaSivaraman Differential Revision: D99133816 fbshipit-source-id: 0c53078992b96828c286f83c68c0694103221ca6
Runtime dependency handling - migrate from `none` to `no_symlink` Summary: Removing `none` means that each enum option labels its own specific behaviour. `no_symlink` replaces none. Reviewed By: JakobDegen Differential Revision: D96349347 fbshipit-source-id: cedcdfc7fada33306e043e0c304395139986782d
Fix python toolchain for buck2-oss-examples Summary: This has been broken since at least November Reviewed By: JakobDegen Differential Revision: D96017772 fbshipit-source-id: 8c4ff7b0cdad74278f8fa1bb033be93c0b7c9494